Skip to content

Conversation

@AdoKevin
Copy link
Contributor

@AdoKevin AdoKevin commented Jul 2, 2025

这个PR的主要修改内容为:

  1. 使用vitest, 将现在的test.js 改造为单元测试,并保存当前的结果为快照
  2. 添加了一个action, 用于pr 提交后自动执行单元测试,并修改了现在的release 流程中的测试步骤为单元测试
  3. 修复了一个问题,部分生成的response 类型没有namespace前缀。提交 7982ab9 可以看到修改前后快照的变更
  4. eslint添加了类型导入的规则并执行了自动修复,代码可读性更好

看看还有没有什么遗漏,请告知

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: c4a421a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-request Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@rookie-luochao rookie-luochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢大佬贡献pr, 我先看看

@rookie-luochao rookie-luochao merged commit 296739e into openapi-ui:main Jul 4, 2025
1 check passed
@rookie-luochao
Copy link
Member

合并代码之后,有些pipeline跑不过了呢

https://github.com/openapi-ui/openapi-ts-request/actions/runs/16070733161

@rookie-luochao
Copy link
Member

rookie-luochao commented Jul 4, 2025

在我这个仓库,好像跑pipeline执行单测过不了

@AdoKevin
Copy link
Contributor Author

AdoKevin commented Jul 4, 2025

在我这个仓库,好像跑pipeline执行单测过不了

我看看原因,起码说明pipeline配置对了,每次用unit 拦截的效果也有了

@rookie-luochao
Copy link
Member

是的,拦截是有效果的

@AdoKevin
Copy link
Contributor Author

AdoKevin commented Jul 4, 2025

看起来新的另外这个PR中的代码有问题, 我看一下, 等下再来一个PR

@rookie-luochao
Copy link
Member

rookie-luochao commented Jul 4, 2025 via email

@AdoKevin
Copy link
Contributor Author

AdoKevin commented Jul 4, 2025

提了一个新的PR #390 解决了, 你看下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants